linux-kernel - Re: [PATCH] xen: xen: compile irq functions without -pg for ftrace

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20080728193235.GB11431@uranus.ravnborg.org>
Date:	Mon, 28 Jul 2008 21:32:35 +0200
From:	Sam Ravnborg <sam@...nborg.org>
To:	Jeremy Fitzhardinge <jeremy@...p.org>
Cc:	Ingo Molnar <mingo@...e.hu>,
	Linux Kernel Mailing List <linux-kernel@...r.kernel.org>,
	"Alex Nixon (Intern)" <Alex.Nixon@...citrix.com>,
	Eduardo Habkost <ehabkost@...hat.com>
Subject: Re: [PATCH] xen: xen: compile irq functions without -pg for ftrace

On Mon, Jul 28, 2008 at 11:53:57AM -0700, Jeremy Fitzhardinge wrote:
> For some reason I managed to miss a bunch of irq-related functions
> which also need to be compiled without -pg when using ftrace.  This
> patch moves them into their own file, and starts a cleanup process
> I've been meaning to do anyway.
> 
> [ Sam, Ingo: I think the problem was that I enabled CONFIG_FTRACE
>  but didn't do a clean build.  Shouldn't the build-system notice
>  that the config changes the CFLAGS and rebuild everything?  That
>  didn't seem to happen in this case. ]

The build system usually does this.
And I have no reports that this has regressed until now.
What file?
Can you tell me how to reproduce it?

> 
> ===================================================================
> --- a/arch/x86/xen/Makefile
> +++ b/arch/x86/xen/Makefile
> @@ -2,9 +2,10 @@
> # Do not profile debug and lowlevel utilities
> CFLAGS_REMOVE_spinlock.o = -pg
> CFLAGS_REMOVE_time.o = -pg
> +CFLAGS_REMOVE_irq.o = -pg
> endif

I already NACK'ed this syntax and described the way it should be done.
Is this ignored or on a TODO list?

	Sam
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/