linux-kernel - Re: [PATCH 0/24] x86: arch/x86/kernel/ cleanups

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <488E377E.6060808@goop.org>
Date:	Mon, 28 Jul 2008 14:17:50 -0700
From:	Jeremy Fitzhardinge <jeremy@...p.org>
To:	"Gustavo F. Padovan" <gustavo@....ic.unicamp.br>
CC:	linux-kernel@...r.kernel.org, mingo@...e.hu
Subject: Re: [PATCH 0/24] x86: arch/x86/kernel/ cleanups

Gustavo F. Padovan wrote:
> Ingo,
>
>
> Ingo,
>
> I removed many extra whitespaces and tabs from arch/x86/kernel/
>   

This is not a good time to be posting this kind of patch.  These kinds 
of trivial cleanups are best done in a late -rc, when the patch rate 
goes down.  However, pure whitespace cleanups  have very little value 
like this, particularly since it looks like you're breaking the 
formatting in some cases.

It would be better to address them in passing if there's some more 
substantial change which needs to be done to the code.  
http://janitor.kernelnewbies.org/ should be a good place to look for 
suggestions.

    J
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/