[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <6b53b1990807281437l707be573n3be4d85feb033c63@mail.gmail.com>
Date: Mon, 28 Jul 2008 18:37:44 -0300
From: "Gustavo F. Padovan" <gustavo@....ic.unicamp.br>
To: "Ingo Molnar" <mingo@...e.hu>
Cc: linux-kernel@...r.kernel.org,
"the arch/x86 maintainers" <x86@...nel.org>
Subject: Re: [PATCH 0/24] x86: arch/x86/kernel/ cleanups
On Mon, Jul 28, 2008 at 6:20 PM, Ingo Molnar <mingo@...e.hu> wrote:
>
> * Gustavo F. Padovan <gustavo@....ic.unicamp.br> wrote:
>
>> Ingo,
>>
>> I removed many extra whitespaces and tabs from arch/x86/kernel/
>
> hm, we tend to do a full cleanup of files we touch for style
> cleanup.
>
> You can check some style errors via:
>
> scripts/checkpatch.pl --file arch/x86/kernel/alternative.c
>
> but it also makes sense to look at the file and figure out places that
> look ugly.
>
>> x86: kernel/alternative.c cleanup
>
> total: 4 errors, 15 warnings, 4 checks, 540 lines checked
>
>> x86: kernel/apm_32.c cleanup
>
> total: 6 errors, 27 warnings, 5 checks, 2416 lines checked
>
> [ etc. ]
>
> If we did each style problem separately we'd be generating over 1
> million commits for the entire tree - that's not feasible. So we go per
> file and once a file has been cleaned up, we keep it clean.
>
> Note, checkpatch errors can be false positives occasionally, and not all
> warnings have to be fixed all the time - ask if unsure about whether to
> fix something or not.
>
> It's also useful to check that the .o's are unchanged after a cleanup.
> You can see commits that do that, for example:
Right. I will do this.
Thanks, Ingo.
>
> commit d4413732b54a17684e48fbb4b52fade5bf965b5d
> Author: Paolo Ciarrocchi <paolo.ciarrocchi@...il.com>
> Date: Tue Feb 19 23:51:27 2008 +0100
>
> x86: coding style fixes to arch/x86/oprofile/op_model_athlon.c
>
> The patch fixes 33 errors and a few warnings reported by checkpatch.pl
>
> arch/x86/oprofile/op_model_athlon.o:
> text data bss dec hex filename
> 1691 0 32 1723 6bb op_model_athlon.o.before
> 1691 0 32 1723 6bb op_model_athlon.o.after
> md5:
> c354bc2d7140e1e626c03390eddaa0a6 op_model_athlon.o.before.asm
> c354bc2d7140e1e626c03390eddaa0a6 op_model_athlon.o.after.asm
>
> Signed-off-by: Paolo Ciarrocchi <paolo.ciarrocchi@...il.com>
> Signed-off-by: Ingo Molnar <mingo@...e.hu>
>
> Ingo
>
--
----------------------------------------------
Gustavo Fernando Padovan
Engenharia de Computação 2006
LAS - Laboratório de Administração e Segurança de Sistemas
Instituto de Computação - UNICAMP
gfpadovan@...il.com
ra061316@...dents.ic.unicamp.br
pao@...ber.org
-------------------------------------------
Seja Livre, use Software Livre
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists