linux-kernel - Re: [PATCH 1/3] cpuset: clean up cpuset hierarchy traversal code

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20080727233746.7f057e74.pj@sgi.com>
Date:	Sun, 27 Jul 2008 23:37:46 -0500
From:	Paul Jackson <pj@....com>
To:	Li Zefan <lizf@...fujitsu.com>
Cc:	akpm@...ux-foundation.org, menage@...gle.com,
	seto.hidetoshi@...fujitsu.com, laijs@...fujitsu.com,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH 1/3] cpuset: clean up cpuset hierarchy traversal code

Li Zefan wrote:
> +	list_add(&top_cpuset.stack_list, &q);

Can you figure out if we are holding any system wide lock, such as
cgroup_mutex, at this point?  There is only one top_cpuset.stack_list
in the system, so I would think that we need to single thread its usage
somehow.

The hotplug hooks, such as common_cpu_mem_hotplug_unplug() that were
added sometime in the last few months (while the so called maintainer,
who's initials seem to be 'pj', was asleep ;) don't describe what
locking applies to them very well, and they call rebuild_sched_domains(),
where the above line of code lives.

-- 
                  I won't rest till it's the best ...
                  Programmer, Linux Scalability
                  Paul Jackson <pj@....com> 1.940.382.4214
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/