linux-kernel - Re: [build error] drivers/char/pcmcia/ipwireless/hardware.c:571: error: invalid use of undefined type 'struct ipw

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20080728220631.GA8095@elte.hu>
Date:	Tue, 29 Jul 2008 00:06:31 +0200
From:	Ingo Molnar <mingo@...e.hu>
To:	Linus Torvalds <torvalds@...ux-foundation.org>
Cc:	Mike Travis <travis@....com>,
	Rusty Russell <rusty@...tcorp.com.au>,
	Linux Kernel Mailing List <linux-kernel@...r.kernel.org>,
	Andrew Morton <akpm@...ux-foundation.org>,
	Al Viro <viro@...IV.linux.org.uk>,
	David Sterba <dsterba@...e.cz>, Jiri Kosina <jkosina@...e.cz>
Subject: Re: [build error] drivers/char/pcmcia/ipwireless/hardware.c:571:
	error: invalid use of undefined type 'struct ipw_network'


* Ingo Molnar <mingo@...e.hu> wrote:

> drivers/char/pcmcia/ipwireless/hardware.c:571: error: invalid use of 
> undefined type 'struct ipw_network'
> 
> http://redhat.com/~mingo/misc/config-Mon_Jul_28_23_36_20_CEST_2008.bad
> 
> probably due to a string of commits to that file from today.

hm, has this version of the driver ever been built successfully? Because 
struct ipw_network is defined in network.c [only], and then used in 
hardware.c.

It could be changed to void * if the structure wasnt relied on by:

                        const int min_capacity =
                                ipwireless_ppp_mru(hw->network + 2);

so changing it to void * would break this part of the code.

furthermore, what does that "hw->network + 2" mean? It points into 
la-la-land AFAICS, because it's initialized as:

        struct ipw_network *network =
                kzalloc(sizeof(struct ipw_network), GFP_ATOMIC);

and then written into hw->network via:

        ipwireless_associate_network(hw, network);

it's getting late here, so i might be missing some really obvious 
solution (and Jiri is asleep i suspect), so below is a temporary patch 
that marks the driver CONFIG_BROKEN until this is resolved. This gets 
allyesconfig going on x86.

	Ingo

--------------->
>From 56df93b08edb33310aaf5c17c48be098d134cc07 Mon Sep 17 00:00:00 2001
From: Ingo Molnar <mingo@...e.hu>
Date: Tue, 29 Jul 2008 00:06:05 +0200
Subject: [PATCH] ipwireless: disable for now
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 8bit

mark it CONFIG_BROKEN for now, it breaks the build:

drivers/char/pcmcia/ipwireless/hardware.c: In function ‘pool_allocate':
drivers/char/pcmcia/ipwireless/hardware.c:571: error: invalid use of undefined type ‘struct ipw_network'

Signed-off-by: Ingo Molnar <mingo@...e.hu>
---
 drivers/char/pcmcia/Kconfig |    1 +
 1 files changed, 1 insertions(+), 0 deletions(-)

diff --git a/drivers/char/pcmcia/Kconfig b/drivers/char/pcmcia/Kconfig
index ffa0efc..8ee7bbd 100644
--- a/drivers/char/pcmcia/Kconfig
+++ b/drivers/char/pcmcia/Kconfig
@@ -46,6 +46,7 @@ config CARDMAN_4040
 config IPWIRELESS
 	tristate "IPWireless 3G UMTS PCMCIA card support"
 	depends on PCMCIA && NETDEVICES
+	depends on BROKEN
 	select PPP
 	help
 	  This is a driver for 3G UMTS PCMCIA card from IPWireless company. In
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/