linux-kernel - Re: [2.6 patch] SH_AP325RXA must select I2C

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20080728223828.GF8301@fluff.org.uk>
Date:	Mon, 28 Jul 2008 23:38:28 +0100
From:	Ben Dooks <ben-linux@...ff.org>
To:	Adrian Bunk <bunk@...nel.org>
Cc:	lethal@...ux-sh.org, Yusuke Goda <goda.yusuke@...esas.com>,
	Magnus Damm <damm@...l.co.jp>, linux-sh@...r.kernel.org,
	linux-kernel@...r.kernel.org
Subject: Re: [2.6 patch] SH_AP325RXA must select I2C

On Mon, Jul 28, 2008 at 11:17:05PM +0300, Adrian Bunk wrote:
> This patch fixes the following build error:
> 
> <--  snip  -->
> 
> ...
>   LD      vmlinux
> arch/sh/boards/renesas/ap325rxa/built-in.o: In function `camera_set_capture':
> setup.c:(.text+0x80): undefined reference to `i2c_get_adapter'
> setup.c:(.text+0x88): undefined reference to `i2c_transfer'
> make[1]: *** [vmlinux] Error 1
> 
> <--  snip  -->
> 
> Reported-by: Adrian Bunk <bunk@...nel.org>
> Signed-off-by: Adrian Bunk <bunk@...nel.org>

I suggest fixing the code or moving out to something that
depends on having I2C available.
 
> ---
> cdcb22706c51f0ae44946f4c3826cc3658960eba 
> diff --git a/arch/sh/Kconfig b/arch/sh/Kconfig
> index 7bfb0d2..6f77d0a 100644
> --- a/arch/sh/Kconfig
> +++ b/arch/sh/Kconfig
> @@ -520,6 +520,7 @@ config SH_MIGOR
>  config SH_AP325RXA
>  	bool "AP-325RXA"
>  	depends on CPU_SUBTYPE_SH7723
> +	select I2C
>  	help
>  	  Renesas "AP-325RXA" support.
>  	  Compatible with ALGO SYSTEM CO.,LTD. "AP-320A"
> 
> --
> To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
> the body of a message to majordomo@...r.kernel.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html
> Please read the FAQ at  http://www.tux.org/lkml/

-- 
Ben (ben@...ff.org, http://www.fluff.org/)

  'a smiley only costs 4 bytes'
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/