linux-kernel - Re: [patch 2.6.26-git] /dev/hpet

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <488D7BFF.10005@ladisch.de>
Date:	Mon, 28 Jul 2008 09:57:51 +0200
From:	Clemens Ladisch <clemens@...isch.de>
To:	David Brownell <david-b@...bell.net>
CC:	lkml <linux-kernel@...r.kernel.org>, bob.picco@...com,
	venkatesh.pallipadi@...el.com, Vojtech Pavlik <vojtech@...e.cz>,
	the arch/x86 maintainers <x86@...nel.org>,
	Adrian Bunk <bunk@...nel.org>
Subject: Re: [patch 2.6.26-git] /dev/hpet - fixes and cleanup

David Brownell wrote:
> ...
> Plus, add a FIXME comment for something that could cause big trouble
> on systems with more capable HPETs than at least Intel seems to ship.
> ...
> +
> +		/* FIXME this may trash both the system clocksource and
> +		 * the current clock event device!  Use HPET_TN_SETVAL
> +		 * instead, like arch/x86/kernel/hpet.c does ... never
> +		 * modify the counter, ever.
> +		 */
>  		m = read_counter(&hpet->hpet_mc);
>  		write_counter(t + m + hpetp->hp_delta, &timer->hpet_compare);

This comment seems to assume that the code below modifies the main
counter, which it doesn't.  Additionally, HPET_TN_SETVAL has the same
value as Tn_VAL_SET_CNF_MASK (from <linux/hpet.h>), which _is_ used.


Regards,
Clemens
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/