linux-kernel - Re: post 2.6.26 requires pciehp_slot_with

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <488D8A2E.5080509@jp.fujitsu.com>
Date:	Mon, 28 Jul 2008 17:58:22 +0900
From:	Kenji Kaneshige <kaneshige.kenji@...fujitsu.com>
To:	Matthew Wilcox <matthew@....cx>
CC:	Jesse Barnes <jbarnes@...tuousgeek.org>,
	Pierre Ossman <drzeus-list@...eus.cx>,
	Alex Chiang <achiang@...com>,
	LKML <linux-kernel@...r.kernel.org>, linux-pci@...r.kernel.org,
	Kristen Accardi <kristen.c.accardi@...el.com>
Subject: Re: post 2.6.26 requires pciehp_slot_with_bus

Matthew Wilcox wrote:
> On Fri, Jul 25, 2008 at 03:18:53PM -0700, Jesse Barnes wrote:
>> I think that's fine (automatically creating duplicate devices with names to 
>> differentiate them), but I think we should also try harder to avoid adding 
>> duplicates.
>>
>> In Pierre's case, and on my T61, there's only one actual hotplug slot 
>> available, but the firmware creates duplicate physical slot numbers and sets 
>> the HP_CAP bit on everything, both of which are obviously wrong (well I 
>> suppose you could pop these chips off the board, but it's not very 
>> practical).  However, afaict that "other" OS uses the _RMV method to 
>> determine whether a given slot is actually hot pluggable.  On my T61 at 
>> least, this seems to be accurate: only one of my EXP* objects has a _RMV 
>> method.
> 
> I think you're getting distracted from the real problem we're trying to
> solve here, the reason for introducing the pci_slot driver in the first
> place: we want to have information on all slots, not just hotplug ones.
> 
> So while this is growing out of the hotplug system, we need to register
> all slots, even ones without _RMV.
> 

I think Jesse's idea is not for breaking pci_slot driver. I think even
with his idea pci_slot driver will detect all slots, but hotplug driver
(e.g. pciehp) will not be registered on some of those slots.

By the way, how is pci_slot driver on your system that has a problem with
pciehp? Does duplicate slot problem happen also with pci_slot driver? 

Thanks,
Kenji Kaneshige

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/