linux-kernel - Re: [PATCH] cpuset: Rework sched domains and CPU hotplug handling

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <1217313654.18049.59.camel@twins>
Date:	Tue, 29 Jul 2008 08:40:54 +0200
From:	Peter Zijlstra <a.p.zijlstra@...llo.nl>
To:	Ingo Molnar <mingo@...e.hu>
Cc:	Max Krasnyansky <maxk@...lcomm.com>, linux-kernel@...r.kernel.org,
	pj@....com, menage@...gle.com, vegard.nossum@...il.com,
	Oleg Nesterov <oleg@...sign.ru>
Subject: Re: [PATCH] cpuset: Rework sched domains and CPU hotplug handling

On Mon, 2008-07-28 at 16:07 +0200, Ingo Molnar wrote:
> * Max Krasnyansky <maxk@...lcomm.com> wrote:
> 
> > Max Krasnyansky wrote:
> > > This is an updated version of my previous cpuset patch:
> > >   "Make rebuild_sched_domains() usable from any context (take 2)"
> > 
> > Folks,
> > 
> > Any comments on this patch ? We need this to complete sched domain 
> > handling fixes/improvements that we started with the cpu_active_map, 
> > and to avoid circular locking issues in the cpu hotplug -> 
> > rebuild_sched_domains path.
> 
> Paul, Peter, any comments?

I'm really not that at home with all that cgroup fiddling, so I'd like a
word from the two Pauls..

Questions I have at the moment:

 -  do we really need a new workqueue for this? Can't we use the regular
keventd stuff, now that Oleg fixed the get_online_cpus() thing?
(3da1c84c00c7e5fa8348336bd8c342f9128b0f14)

 - aren't there funny races with the async_rebuild_sched_domains()
stuff? 

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/