linux-kernel - Re: [PATCH] bcm5974-0.58: name changes, open/close and suspend/resume serialized

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <1217313973.15381.9.camel@johannes.berg>
Date:	Tue, 29 Jul 2008 08:46:13 +0200
From:	Johannes Berg <johannes@...solutions.net>
To:	Dmitry Torokhov <dmitry.torokhov@...il.com>
Cc:	Henrik Rydberg <rydberg@...omail.se>, linux-input@...r.kernel.org,
	linux-kernel@...r.kernel.org, robfitz@...k.net, akpm@...l.org,
	jikos@...os.cz, vojtech@...e.cz, dmonakhov@...nvz.org
Subject: Re: [PATCH] bcm5974-0.58: name changes, open/close and
	suspend/resume serialized

On Tue, 2008-07-29 at 01:41 -0400, Dmitry Torokhov wrote:

> > one thing about the drivers/input/mouse/Kconfig patch:
> > 
> > The original version contained "select USB", which was later changed
> > to "depends on USB" by Andrew Morton. I saw it reappear as "select USB"
> > in your latest patch, and simply considered it a change back, but
> > maybe it was an oversight?
> > 
> 
> I am of the opinion that it is OK to "select" high-level subsystems that
> don't have additional dependencies, especially if they are "past" the
> original driver in menuconfig. I don't really like the idea of forcing
> users revisiting earlier sub-menus after they selected a new subsystem
> to see if there are any new options. Plus, if user wants driver for his
> touchpad he does not really care whether it is PS/2 or USB, [s]he just
> wants it to work.

USB tends to have implicit dependencies like the ehci/ohci/uhci
controller though, so it's not going to work like that anyway starting
from a minimal config, and all defconfigs probably have USB anyway.

Therefore, I personally would keep it as "depends on" rather than
"select". YMMV.

johannes

Download attachment "signature.asc" of type "application/pgp-signature" (837 bytes)