| lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
|
Open Source and information security mailing list archives
| ||
|
Date: Tue, 29 Jul 2008 11:28:47 +0200 From: Heiko Carstens <heiko.carstens@...ibm.com> To: Matthew Wilcox <matthew@....cx> Cc: linux-ia64@...r.kernel.org, linux-kernel@...r.kernel.org Subject: Re: Is topology_core_siblings for use by drivers? On Tue, Jul 29, 2008 at 01:14:22AM -0600, Matthew Wilcox wrote: > > allmodconfig currently dies with: > > ERROR: "cpu_core_map" [drivers/net/sfc/sfc.ko] undefined! > > $ grep -r cpu_core_map include/asm-ia64/ > include/asm-ia64/smp.h:extern cpumask_t cpu_core_map[NR_CPUS]; > include/asm-ia64/topology.h:#define topology_core_siblings(cpu) (cpu_core_map[cpu]) > > OK ... it's not exported to modules. Do other architectures have this > problem? > > $ grep topology_core_siblings include/asm-*/topology.h > include/asm-ia64/topology.h:#define topology_core_siblings(cpu) (cpu_core_map[cpu]) > include/asm-powerpc/topology.h:#define topology_core_siblings(cpu) (per_cpu(cpu_core_map, cpu)) > include/asm-s390/topology.h:#define topology_core_siblings(cpu) (cpu_core_map[cpu]) > include/asm-x86/topology.h:#define topology_core_siblings(cpu) (per_cpu(cpu_core_map, cpu)) > > s390, I guess. But they don't have PCI device drivers. Yes, luckily it doesn't get compiled on s390. Btw. the for_each_online_cpu loop where this gets used doesn't seem to be save wrt cpu hotplug. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists