[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <20080729141835.GC902@linux-sh.org>
Date: Tue, 29 Jul 2008 23:18:35 +0900
From: Paul Mundt <lethal@...ux-sh.org>
To: Vivek Goyal <vgoyal@...hat.com>
Cc: Simon Horman <horms@...ge.net.au>,
Andrew Morton <akpm@...ux-foundation.org>,
Muli Ben-Yehuda <muli@...ibm.com>,
Tony Luck <tony.luck@...el.com>, linux-ia64@...r.kernel.org,
Chandru <chandru@...ibm.com>, kexec@...ts.infradead.org,
linux-kernel@...r.kernel.org, Terry Loftin <terry.loftin@...com>,
"Eric W. Biederman" <ebiederm@...ssion.com>,
Ingo Molnar <mingo@...e.hu>,
Linus Torvalds <torvalds@...ux-foundation.org>,
Paul Mackerras <paulus@...ba.org>, linuxppc-dev@...abs.org
Subject: Re: [PATCH 5/5] sh: Define elfcorehdr_addr in arch dependent section
On Mon, Jul 28, 2008 at 05:15:14PM -0400, Vivek Goyal wrote:
> o Move elfcorehdr_addr definition in arch dependent crash dump file. This is
> equivalent to defining elfcorehdr_addr under CONFIG_CRASH_DUMP instead of
> CONFIG_PROC_VMCORE. This is needed by is_kdump_kernel() which can be
> used irrespective of the fact whether CONFIG_PROC_VMCORE is enabled or
> not.
>
> o I don't see sh setup code parsing the command line for elfcorehdr_addr. I
> am wondering how does vmcore interface work on sh. Anyway, I am atleast
> defining elfcoredhr_addr so that compilation is not broken on sh.
>
Hmm, you are correct, it seems like it was either lost in a merge
somewhere or I simply neglected to check it in it when I was testing this
stuff initially. Thanks for noticing!
> Signed-off-by: Vivek Goyal <vgoyal@...hat.com>
Acked-by: Paul Mundt <lethal@...ux-sh.org>
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists