linux-kernel - Subtle but oops causing problem with class

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [thread-next>] [day] [month] [year] [list]

Date:	Tue, 29 Jul 2008 12:42:28 -0500
From:	James Bottomley <James.Bottomley@...senPartnership.com>
To:	Kay Sievers <kay.sievers@...y.org>, Hannes Reinecke <hare@...e.de>
Cc:	linux-scsi <linux-scsi@...r.kernel.org>,
	linux-kernel <linux-kernel@...r.kernel.org>
Subject: Subtle but oops causing problem with class_device->device
	conversion

It's taken me a while to track this down.  Basically there's an oops in
scsi_transport_spi that's directly caused by this.

What happened is that you made all class devices become real devices and
be parented to devices they were formerly allied to through the class
device dev pointer.  This means that effectively you expanded the child
list of every device to include not only its real children but also its
class devices.

This breaks in device_for_each_child *if* the routine in the iterator
doesn't perform checks on the devices it gets back (scsi_transport_spi
was assuming that every device it got was embedded in a struct
scsi_device because they're the only logical children of a scsi_target).

I can fix the SCSI breakage, but the whole tree will need auditing to
check that nothing else is using this assumption.

James

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/