linux-kernel - Re: [patch 2/2] Remove a few inlines in fs/namei.c

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [thread-next>] [day] [month] [year] [list]

Date:	Tue, 29 Jul 2008 19:55:37 +0100
From:	Al Viro <viro@...IV.linux.org.uk>
To:	Thomas Petazzoni <thomas.petazzoni@...e-electrons.com>
Cc:	linux-kernel@...r.kernel.org, linux-fsdevel@...r.kernel.org,
	akpm@...ux-foundation.org
Subject: Re: [patch 2/2] Remove a few inlines in fs/namei.c

On Tue, Jul 29, 2008 at 05:52:31PM +0200, Thomas Petazzoni wrote:
> Uninline may_create() and do_follow_link() and use vfs_follow_link()
> instead of __vfs_follow_link() in __do_follow_link(). It allows to
> slightly reduce the size of kernel code:
> 
>    text	   data	    bss	    dec	    hex	filename
> 1114299	 118564	 212992	1445855	 160fdf	vmlinux.old
> 1112971	 118564	 212992	1444527	 160aaf	vmlinux
>   -1328       0       0   -1328    -530 +/-
> 
> This patch is part of the Linux Tiny project and has been originally
> written by Matt Mackall <mpm@...enic.com>

Absolutely not.  do_follow_link() et.al. are parts of mutual recursion
loop and we need to reduce the use of kernel *stack*.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/