linux-kernel - Re: [patch 2.6.26-git] /dev/hpet

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <200807291246.26156.david-b@pacbell.net>
Date:	Tue, 29 Jul 2008 12:46:25 -0700
From:	David Brownell <david-b@...bell.net>
To:	Clemens Ladisch <clemens@...isch.de>
Cc:	lkml <linux-kernel@...r.kernel.org>, bob.picco@...com,
	venkatesh.pallipadi@...el.com, Vojtech Pavlik <vojtech@...e.cz>,
	the arch/x86 maintainers <x86@...nel.org>,
	Adrian Bunk <bunk@...nel.org>
Subject: Re: [patch 2.6.26-git] /dev/hpet - fixes and cleanup

On Monday 28 July 2008, Clemens Ladisch wrote:
> David Brownell wrote:
> > Oh ... I see.  It's called write_counter() but doesn't
> > actually write the counter.  Likewise, read_counter() is
> > not actually reading the counter.  Gaack ...
> 
> A more correct name would be something like
> write_a_register_that_has_the_same_size_as_a_counter_register().

writel() would be my choice ... :)

I don't think anything in that code really needs to modify the
upper 32 bits of those registers.  And nothing except the ia64
HPET clocksource needs to read them either.

 
> I'm hoping that I can deprecate and delete much of this code without
> having to clean it up first.

I'm not sure how practical that goal is, but I agree that there
seems to be no point to /dev/hpet ... certainly, you could start
by deprecating it and making sure distroes don't enable it.


> > Any comments on the rest?
> 
> Looks fine.  I would have preferred a series of smaller patches, but my
> feelings on this are not strong enough to split it myself or to ask you
> to do it.

OK, I'll send along the updated patch (against 2.6.27-rc1).

- Dave
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/