lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Tue, 29 Jul 2008 23:15:35 +0200 From: "Rafael J. Wysocki" <rjw@...k.pl> To: Greg KH <greg@...ah.com>, Ben Collins <ben.collins@...onical.com> Cc: linux-kernel@...r.kernel.org, Pavel Machek <pavel@....cz>, pm list <linux-pm@...ts.linux-foundation.org> Subject: Re: [PATCH 6/7] pm: Config option to disable handling of console during suspend/resume On Tuesday, 29 of July 2008, Greg KH wrote: > On Sun, Jul 20, 2008 at 09:48:28PM -0400, Ben Collins wrote: > > Config option allows userspace to handle console during suspend/resume > > instead of the kernel. > > > > Signed-off-by: Ben Collins <ben.collins@...onical.com> > > --- > > kernel/power/Kconfig | 15 +++++++++++++++ > > kernel/power/console.c | 4 ++++ > > 2 files changed, 19 insertions(+), 0 deletions(-) > > > > diff --git a/kernel/power/Kconfig b/kernel/power/Kconfig > > index b45da40..6855299 100644 > > --- a/kernel/power/Kconfig > > +++ b/kernel/power/Kconfig > > @@ -105,6 +105,21 @@ config SUSPEND_FREEZER > > > > Turning OFF this setting is NOT recommended! If in doubt, say Y. > > > > +config PM_DISABLE_CONSOLE > > + bool "Disable Power Management messing with the active console" > > + depends on PM > > + default n > > + ---help--- > > + By default, PM will take over the active console (generally, this means > > + switching to the console when suspending from X). This can at times cause > > + problems, especially if userspace suspend scripts try to do things with > > + the console before or after suspending (e.g. calling vbestate). > > + > > + To work around this, enable this option so that PM will not handle the > > + console. > > + > > + If unsure, say N. > > + > > config HIBERNATION > > bool "Hibernation (aka 'suspend to disk')" > > depends on PM && SWAP && ARCH_HIBERNATION_POSSIBLE > > diff --git a/kernel/power/console.c b/kernel/power/console.c > > index b8628be..8b9706f 100644 > > --- a/kernel/power/console.c > > +++ b/kernel/power/console.c > > @@ -33,6 +33,7 @@ EXPORT_SYMBOL(pm_set_vt_switch); > > > > int pm_prepare_console(void) > > { > > +#ifndef CONFIG_PM_DISABLE_CONSOLE > > Can't you do this in a .h file instead? > > And is this really needed? Why has no other distro needed this change? > What is so wierd about your suspend setup to require this? Reportedly, some systems have problems with graphics restoration from user space if the switch is done. Anyway, I'd prefer to use the (already existing) pm_set_vt_switch() thing for that, maybe with the help of a command line parameter, to adding the .config option like this. Thanks, Rafael -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists