linux-kernel - Re: [RESEND x2 PATCH 2.6.26-git 1/2] MTD DataFlash: bugfix, binary page sizes now handled (v3)

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20080729213733.3345546a.akpm@linux-foundation.org>
Date:	Tue, 29 Jul 2008 21:37:33 -0700
From:	Andrew Morton <akpm@...ux-foundation.org>
To:	David Brownell <david-b@...bell.net>
Cc:	linux-mtd@...ts.infradead.org, dwmw2@...radead.org,
	Bryan Wu <cooloney@...nel.org>,
	Michael Hennerich <michael.hennerich@...log.com>,
	linux-kernel@...r.kernel.org
Subject: Re: [RESEND x2 PATCH 2.6.26-git 1/2] MTD DataFlash: bugfix, binary
 page sizes now handled (v3)

On Sun, 27 Jul 2008 03:25:13 -0700 David Brownell <david-b@...bell.net> wrote:

> From: David Brownell <dbrownell@...rs.sourceforge.net>
> 
> The wrong version of the "teach dataflash about binary density" patch
> just got merged (v2 not v3) ... this restores the missing updates:
> 
>   * Fix the cmdlinepart *regression* that caused testing failures (!!)
>     by restoring the original part labels in relevant cases.
> 
>   * Don't reference things that don't exist (!)
> 	- An opcode that doesn't even exist for DataFlash
> 	- The part is "at45db642" not "at45db641"
> 	- ID zero in this JEDEC table
> 
>   * Make the JEDEC probe routine report and handle errors better:
> 	- If the SPI calls fail, return the error codes.
> 	- Don't depend on ordering of table entries.
> 	- Unrecognized ids are different from parts that have no ID.
>           We won't actually know how to handle them correctly; display
> 	  the ID and ignore the chip.
> 
>   * Move the original block comment about the "legacy" chip ID scheme
>     back next to the code to which it applies ... not next to the new
>     JEDEC query code, which uses an entirely different strategy.
> 
>   * Don't print a guessed erasesize; /proc/mtd has the real value.
> 
> And add a few more comments.
> 

drivers/mtd/devices/mtd_dataflash.c: In function 'jedec_probe':
drivers/mtd/devices/mtd_dataflash.c:611: error: incompatible type for argument 1 of 'dev_name'
drivers/mtd/devices/mtd_dataflash.c:619: error: incompatible type for argument 1 of 'dev_name'

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/