linux-kernel - Re: RFC [PATCH] x86: introduce nr

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20080730100926.GA10431@elte.hu>
Date:	Wed, 30 Jul 2008 12:09:26 +0200
From:	Ingo Molnar <mingo@...e.hu>
To:	Yinghai Lu <yhlu.kernel@...il.com>
Cc:	Thomas Gleixner <tglx@...utronix.de>,
	"H. Peter Anvin" <hpa@...or.com>,
	"Eric W. Biederman" <ebiederm@...ssion.com>,
	Dhaval Giani <dhaval@...ux.vnet.ibm.com>,
	Mike Travis <travis@....com>,
	Andrew Morton <akpm@...ux-foundation.org>,
	linux-kernel@...r.kernel.org
Subject: Re: RFC [PATCH] x86: introduce nr_irqs for 64bit

* Yinghai Lu <yhlu.kernel@...il.com> wrote:

> add DEFINE_DYN_ARRAY for dynamical array support
> 
> todo:
> 1. convert x86 32bit and other arch
> 2. nr_irqs auto probe via acpi_oem_check?
> 
> Signed-off-by: Yinghai Lu <yhlu.kernel@...il.com>

wonderful!

I have one main structural suggestion: could we please keep the NR_IRQS 
name, and just change it to dynamic on x86? NR_IRQS is used in 540 
places in the kernel, there's no point in touching all that code.

Also add an CONFIG_ARCH_HAS_DYNAMIC_NR_IRQS switch, define it in 
arch/x86/Kconfig and use it in include/linux/irq.h.

This will create far less migration pain than the widespread rename. 
That will also solve the "what about the other architectures" question.

	Ingo
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/