lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Wed, 30 Jul 2008 03:35:23 -0700 From: Andrew Morton <akpm@...ux-foundation.org> To: Rusty Russell <rusty@...tcorp.com.au> Cc: lguest <lguest@...abs.org>, linux-kernel@...r.kernel.org, Nick Piggin <nickpiggin@...oo.com.au> Subject: Re: [PATCH 1/2] Export get_user_pages_fast On Wed, 30 Jul 2008 14:38:55 +1000 Rusty Russell <rusty@...tcorp.com.au> wrote: > After all, it was made for lguest wasn't it? Still think it should be > called get_current_pages() though. > > Signed-off-by: Rusty Russell <rusty@...tcorp.com.au> > --- > arch/x86/mm/gup.c | 2 ++ > 1 file changed, 2 insertions(+) > > diff -r cb465381f6d5 arch/x86/mm/gup.c > --- a/arch/x86/mm/gup.c Wed Jul 30 10:18:44 2008 +1000 > +++ b/arch/x86/mm/gup.c Wed Jul 30 14:22:53 2008 +1000 > @@ -8,6 +8,7 @@ > #include <linux/mm.h> > #include <linux/vmstat.h> > #include <linux/highmem.h> > +#include <linux/module.h> > > #include <asm/pgtable.h> > > @@ -296,3 +303,4 @@ slow_irqon: > return ret; > } > } > +EXPORT_SYMBOL_GPL(get_user_pages_fast); A regularly-occurring problem with an export like this is that someone writes a driver and tests it on x86, then the driver explodes on an architecture which didn't export the same symbol. So a better implementation might be to put #ifdef CONFIG_HAVE_GET_USER_PAGES_FAST EXPORT_SYMBOL_GPL(get_user_pages_fast); #endif into generic code somewhere. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists