linux-kernel - Re: 2.6.27-rc1 oops on boot -- cs423x? (Corrected subject)

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <200807300759.55649.bjorn.helgaas@hp.com>
Date:	Wed, 30 Jul 2008 07:59:55 -0600
From:	Bjorn Helgaas <bjorn.helgaas@...com>
To:	Rene Herman <rene.herman@...access.nl>
Cc:	Pete Clements <clem@...m.clem-digital.net>,
	linux-kernel <linux-kernel@...r.kernel.org>
Subject: Re: 2.6.27-rc1 oops on boot -- cs423x? (Corrected subject)

On Wednesday 30 July 2008 6:15:07 am Rene Herman wrote:
> On 30-07-08 05:59, Bjorn Helgaas wrote:
> > PNP: fix formatting of dbg_pnp_show_resources() output
> >
> > From: Bjorn Helgaas <bjorn.helgaas@...com>
> >
> > Each resource should be printed on its own line, so start snprintf'ing
> > at the beginning of the buffer every time through the loop.
> >
> > Signed-off-by: Bjorn Helgaas <bjorn.helgaas@...com>
>
> Good WARN_ON() that...
>
> I was looking at why I hadn't seen this here even with the same hardware
> when I _did_ see it here. Most definitely did not back when I was paying
> attention -- although there seems to be little opportunity for that.
>
> Just for my own education; did something recent happen to bring this on
> or must this have been present always? Serious buglet it seems.

That function used to printk the resource piece-meal -- first the
resource type, then the value, then the flags, etc.  I made a late
change to snprintf everything into the buffer, then do a single
printk to keep everything atomic, and I didn't test it well enough.

Bjorn
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/