linux-kernel - Re: [PATCH] mISDN cleanup user interface

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Wed, 30 Jul 2008 17:08:20 +0200
From:	Karsten Keil <kkeil@...e.de>
To:	David Woodhouse <dwmw2@...radead.org>
Cc:	Karsten Keil <kkeil@...e.de>, isdn4linux@...tserv.isdn4linux.de,
	Linus Torvalds <torvalds@...ux-foundation.org>,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH] mISDN cleanup user interface

On Tue, Jul 29, 2008 at 09:22:26PM +0100, David Woodhouse wrote:
> On Tue, 2008-07-29 at 21:56 +0200, Karsten Keil wrote:
> > Please pull from git://git.kernel.org/pub/scm/linux/kernel/git/kkeil/ISDN-2.6.git master
> > 
> > The channelmap should have the same size on 32 and 64 bit
> > systems. Thanks to David Woodhouse for spotting this.
> > 
> > Signed-off-by: Karsten Keil <kkeil@...e.de>
> 
> Er, isn't that still broken? Consider 32-bit userspace on 64-bit kernel,
> big-endian.
> 

URGH, you are right, using the bit operations here is not a good idea at
all and currently we also need not to be atomic for this map so we can use a
bytearray and simple operation here.

-- 
Karsten Keil
SuSE Labs
ISDN and VOIP development
SUSE LINUX Products GmbH, Maxfeldstr.5 90409 Nuernberg, GF: Markus Rex, HRB 16746 (AG Nuernberg)
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/