linux-kernel - Re: [PATCH] Fix miscalculation of sg_io timeout in CDROM_SEND

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Wed, 30 Jul 2008 10:18:53 -0500
From:	James Bottomley <James.Bottomley@...senPartnership.com>
To:	Tim Wright <timw@...hi.com>
Cc:	linux-kernel@...r.kernel.org, linux-scsi@...r.kernel.org
Subject: Re: [PATCH] Fix miscalculation of sg_io timeout in
	CDROM_SEND_PACKET handler.

On Sun, 2008-07-27 at 17:50 -0700, Tim Wright wrote:
> @@ -629,7 +629,7 @@ int scsi_cmd_ioctl(struct file *file, st
>                         hdr.sbp = cgc.sense;
>                         if (hdr.sbp)
>                                 hdr.mx_sb_len = sizeof(struct 
> request_sense);
> -                       hdr.timeout = cgc.timeout;
> +                       hdr.timeout = jiffies_to_msecs(cgc.timeout);
>                         hdr.cmdp = ((struct cdrom_generic_command 
> __user*) arg)->cmd;
>                         hdr.cmd_len = sizeof(cgc.cmd);

I'm afraid this patch is completely whitespace damaged:  the tabs have
all become spaces and the mailer has broken some of the lines.

Since it's a one liner, I can make the fix directly, but if you look at

Documentation/SubmittingPatches

It has some good advice about how to fix your email tool to prevent this
from happening in future.

James


--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/