linux-kernel - Re: [patch v3] splice: fix race with page invalidation

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <E1KOJ1s-0002a5-Im@pomaz-ex.szeredi.hu>
Date:	Wed, 30 Jul 2008 23:16:16 +0200
From:	Miklos Szeredi <miklos@...redi.hu>
To:	torvalds@...ux-foundation.org
CC:	miklos@...redi.hu, jens.axboe@...cle.com,
	akpm@...ux-foundation.org, nickpiggin@...oo.com.au,
	linux-fsdevel@...r.kernel.org, linux-kernel@...r.kernel.org,
	linux-mm@...ck.org
Subject: Re: [patch v3] splice: fix race with page invalidation

> On Wed, 30 Jul 2008, Miklos Szeredi wrote:
> > 
> > It _is_ a bug fix.
> 
> No it's not.
> 
> It's still papering over a totally unrelated bug. It's not a "fix", it's a 
> "paper-over". It doesn't matter if _behaviour_ changes.
> 
> Can you really not see the difference?
> 
> Afaik, everybody pretty much agreed what the real fix should be (don't 
> mark the page not up-to-date, just remove it from the radix tree)

Huh?  I did exactly that, and that patch got NAK'ed by you and Nick:

http://lkml.org/lkml/2008/6/25/230
http://lkml.org/lkml/2008/7/7/21

Confused.

> I'm not seeing why you continue to push the patch that ALREADY GOT
> NAK'ed.

And later ACK'ed by Nick.

There's everything here but agreement about a solution :)

Miklos
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/