linux-kernel - Re: [patch] vfs: make security_inode

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:	Thu, 31 Jul 2008 07:52:42 +1000 (EST)
From:	James Morris <jmorris@...ei.org>
To:	Stephen Smalley <sds@...ho.nsa.gov>
cc:	Miklos Szeredi <miklos@...redi.hu>, viro@...IV.linux.org.uk,
	Andrew Morton <akpm@...ux-foundation.org>,
	linux-security-module@...r.kernel.org,
	linux-fsdevel@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [patch] vfs: make security_inode_setattr() calling consistent

On Wed, 30 Jul 2008, Stephen Smalley wrote:

> Unfortunate since we'd prefer to have the DAC checks applied first, and
> since inode_change_ok() may alter the ia_mode in response to those
> checks, but it does seem inconsistent at present and it doesn't yield
> any difference in the ltp selinux testsuite results.

No LSM seems to be using ia_mode, so that aspect is ok.  The DAC checks 
are generally not being applied first currently, so common case behaviour 
doesn't change with this patch.

Acked-by: James Morris <jmorris@...ei.org>

-- 
James Morris
<jmorris@...ei.org>
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/