linux-kernel - Re: [PATCH] paravirt_ops: Use unsigned long instead of u32 for alloc

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Wed, 30 Jul 2008 14:59:53 -0700
From:	Zachary Amsden <zach@...are.com>
To:	Jeremy Fitzhardinge <jeremy@...p.org>
Cc:	Eduardo Habkost <ehabkost@...hat.com>, Ingo Molnar <mingo@...e.hu>,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] paravirt_ops: Use unsigned long instead of u32 for
	alloc_p*() pfn args

On Wed, 2008-07-30 at 14:51 -0700, Jeremy Fitzhardinge wrote:
> Eduardo Habkost wrote:
> > This patch changes the pfn args from 'u32' to 'unsigned long'
> > on alloc_p*() functions on paravirt_ops, and the corresponding
> > implementations for Xen and VMI. The prototypes for CONFIG_PARAVIRT=n
> > are already using unsigned long, so paravirt.h now matches the prototypes
> > on asm-x86/pgalloc.h.
> >
> > It shouldn't result in any changes on generated code on 32-bit, with
> > or without CONFIG_PARAVIRT. On both cases, 'codiff -f' didn't show any
> > change after applying this patch.
> >
> > On 64-bit, there are (expected) binary changes only when CONFIG_PARAVIRT
> > is enabled, as the patch is really supposed to change the size of the
> > pfn args.
> >
> > Signed-off-by: Eduardo Habkost <ehabkost@...hat.com>
> >
> Acked-by: Jeremy Fitzhardinge <jeremy.fitzhardinge@...rix.com>
> 
> Cc:ing Zach, since it touches vmi.

Thanks, looks good to me.  I always thought u32 is ugly type name anyway.

Acked-by: Zachary Amsden <zach@...are.com>

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/