linux-kernel - Re: [PATCH] blackfin / h8300 build error fix

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Wed, 30 Jul 2008 23:26:47 -0400
From:	"Mike Frysinger" <vapier.adi@...il.com>
To:	"Andrew Morton" <akpm@...ux-foundation.org>
Cc:	"Yoshinori Sato" <ysato@...rs.sourceforge.jp>,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH] blackfin / h8300 build error fix

On Wed, Jul 30, 2008 at 4:01 PM, Andrew Morton wrote:
> On Wed, 30 Jul 2008 15:22:38 -0400 Yoshinori Sato wrote:
>> At Wed, 30 Jul 2008 12:11:37 -0400 Mike Frysinger wrote:
>> > On Wed, Jul 30, 2008 at 11:58 AM, Yoshinori Sato wrote:
>> > > init/main.c:781: undefined reference to `___early_initcall_end'
>> > >
>> > > Signed-off-by: Yoshinori Sato <ysato@...rs.sourceforge.jp>
>> > >
>> > > ---
>> > >  include/asm-generic/vmlinux.lds.h |    2 +-
>> > >  1 files changed, 1 insertions(+), 1 deletions(-)
>> > >
>> > > diff --git a/include/asm-generic/vmlinux.lds.h b/include/asm-generic/vmlinux.lds.h
>> > > index 6d88a92..07b2784 100644
>> > > --- a/include/asm-generic/vmlinux.lds.h
>> > > +++ b/include/asm-generic/vmlinux.lds.h
>> > > @@ -362,7 +362,7 @@
>> > >
>> > >  #define INITCALLS                                                      \
>> > >        *(.initcallearly.init)                                          \
>> > > -       __early_initcall_end = .;                                       \
>> > > +       VMLINUX_SYMBOL(__early_initcall_end) = .;                       \
>> > >        *(.initcall0.init)                                              \
>> > >        *(.initcall0s.init)                                             \
>> > >        *(.initcall1.init)                                              \
>> > > --
>> > > 1.5.6.3
>> >
>> > nice catch, thanks ... looks like BUG_TABLE, TRACEDATA, and PERCPU are
>> > also broken, but blackfin/etc... arent using those which is why we
>> > havent noticed yet ...
>> > -mike
>>
>> Thanks.
>> I fixed same.
>>
>> Signed-off-by: Yoshinori Sato <ysato@...rs.sourceforge.jp>
>>
>>  include/asm-generic/vmlinux.lds.h |   14 +++++++-------
>>  1 files changed, 7 insertions(+), 7 deletions(-)
>>
>> diff --git a/include/asm-generic/vmlinux.lds.h b/include/asm-generic/vmlinux.lds.h
>> index 6d88a92..04cae96 100644
>> --- a/include/asm-generic/vmlinux.lds.h
>> +++ b/include/asm-generic/vmlinux.lds.h
>> @@ -333,9 +333,9 @@
>>  #define BUG_TABLE                                                    \
>>       . = ALIGN(8);                                                   \
>>       __bug_table : AT(ADDR(__bug_table) - LOAD_OFFSET) {             \
>> -             __start___bug_table = .;                                \
>> +             VMLINUX_SYMBOL(__start___bug_table) = .;                \
>>               *(__bug_table)                                          \
>> -             __stop___bug_table = .;                                 \
>> +             VMLINUX_SYMBOL(__stop___bug_table) = .;                 \
>>       }
>
> Sorry, but I haven't been following this topic very well and I rather
> dislike plucking unchangelogged patches out of the middle of email
> discussions.
>
> If there's some patch which I should be applying then please resend it,
> with a meaningful title, a description of what it does, etc.

i thought the fix was self-evident ;)

you cant just use straight symbol names in common header files as they
dont take into consideration weird arch-specific ABI conventions.  in
the case of Blackfin/h8300, the ABI dictates that any C-visible
symbols have an underscore prefixed to them.  thus all symbols in
vmlinux.lds.h need to be wrapped in VMLINUX_SYMBOL() so that each arch
can put hide this magic in their own files.
-mike
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/