linux-kernel - Re: [Linux-fbdev-devel] [PATCH] atyfb

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [day] [month] [year] [list]

Message-Id: <20080731082945.6AEA31E3074@f03.poczta.interia.pl>
Date:	31 Jul 2008 10:29:45 +0200
From:	krzysztof.h1@...zta.fm
To:	"M. Asselstine" <asselsm@...aster.ca>,
	Alexander Beregalov <a.beregalov@...il.com>
Cc:	"kernel-janitors@...r.kernel.org" <kernel-janitors@...r.kernel.org>,
	"syrjala@....fi" <syrjala@....fi>,
	"linux-fbdev-devel@...ts.sourceforge.net" 
	<linux-fbdev-devel@...ts.sourceforge.net>,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
	"adaplas@...il.com" <adaplas@...il.com>
Subject: Re: [Linux-fbdev-devel] [PATCH] atyfb_base.c: fix warning

> On Wed, Jul 30, 2008 at 5:03 PM, Alexander Beregalov
> <a.beregalov@...il.com> wrote:
> > From: Alexander Beregalov <a.beregalov@...il.com>
> >
> > atyfb_base.c: fix warning
> >
> > drivers/video/aty/atyfb_base.c:2663: warning: 'aty_resume_chip' defined
> > but not used
> >
> > Signed-off-by: Alexander Beregalov <a.beregalov@...il.com>
> > Cc: Ville Syrjala <syrjala@....fi>
> > Cc: Antonino A. Daplas <adaplas@....net>
> 
> Looks good, should you maybe move the aty_resume_chip() up into the
> existing #if defined(CONFIG_PM) &&... that atyfb_pci_resume() is in?
> Not sure, just a thought.
> 

The same thought has crossed my mind. Kill the forward declaration and move this short function before atyfb_pci_resume().

Regards,
Krzysztof 


----------------------------------------------------------------------
W kosciele tez zdarzaja sie wpadki!
Smieszny filmik >>> http://link.interia.pl/f1e61

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/