linux-kernel - Re: [PATCH] serial: change remove NR

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <m1iqum2rya.fsf@frodo.ebiederm.org>
Date:	Thu, 31 Jul 2008 04:50:21 -0700
From:	ebiederm@...ssion.com (Eric W. Biederman)
To:	Yinghai Lu <yhlu.kernel@...il.com>
Cc:	Ingo Molnar <mingo@...e.hu>, Thomas Gleixner <tglx@...utronix.de>,
	"H. Peter Anvin" <hpa@...or.com>,
	Dhaval Giani <dhaval@...ux.vnet.ibm.com>,
	Mike Travis <travis@....com>,
	Andrew Morton <akpm@...ux-foundation.org>,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH] serial: change remove NR_IRQS in 8250.c

> replace
> 	[PATCH] serial: change irq_lists to use dyn_array
> use small array with index to handle irq locking for serial port
> hope 32 slot is enough

Could you size this array by NR_UARTS (our worst case usage)
and place irq_no in struct irq_info?

Also you want to hold irq_info->lock when you set or clear irq_no.
Just to be on the safe side.  I expect we can avoid clearing the irq_no
in the irq_lists and prevent a few more races from being a possibility.

Eric
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/