linux-kernel - [RFC:Patch: 003/008](memory hotplug) check node online in __alloc

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Thu, 31 Jul 2008 20:58:26 +0900
From:	Yasunori Goto <y-goto@...fujitsu.com>
To:	Badari Pulavarty <pbadari@...ibm.com>
Cc:	Andrew Morton <akpm@...ux-foundation.org>,
	Mel Gorman <mel@....ul.ie>,
	Christoph Lameter <cl@...ux-foundation.org>,
	linux-mm <linux-mm@...ck.org>,
	Linux Kernel ML <linux-kernel@...r.kernel.org>
Subject: [RFC:Patch: 003/008](memory hotplug) check node online in __alloc_pages


This is to add pgdat_remove_read_lock()/unlock() for parsing zonelist in
__alloc_pages_internal().
The node might be removed before pgdat_remove_read_lock(),
node_online() must be checked at first. If offlined, don't parse it.

Signed-off-by: Yasunori Goto <y-goto@...fujitsu.com>

---
 mm/page_alloc.c |   36 ++++++++++++++++++++++++++++++++++--
 1 file changed, 34 insertions(+), 2 deletions(-)

Index: current/mm/page_alloc.c
===================================================================
--- current.orig/mm/page_alloc.c	2008-07-31 19:01:46.000000000 +0900
+++ current/mm/page_alloc.c	2008-07-31 19:19:19.000000000 +0900
@@ -1394,10 +1394,22 @@ get_page_from_freelist(gfp_t gfp_mask, n
 	int zlc_active = 0;		/* set if using zonelist_cache */
 	int did_zlc_setup = 0;		/* just call zlc_setup() one time */
 
+	pgdat_remove_read_lock();
+	if (unlikely(!node_online(zonelist_nid))) {
+		/*
+		 * Pgdat removing worked before here.
+		 * Don't touch pgdat/zone/zonelist any more.
+		 */
+		pgdat_remove_read_unlock();
+		return NULL;
+	}
+
 	(void)first_zones_zonelist(zonelist, high_zoneidx, nodemask,
 							&preferred_zone);
-	if (!preferred_zone)
+	if (!preferred_zone) {
+		pgdat_remove_read_unlock();
 		return NULL;
+	}
 
 	classzone_idx = zone_idx(preferred_zone);
 
@@ -1451,6 +1463,7 @@ try_next_zone:
 		zlc_active = 0;
 		goto zonelist_scan;
 	}
+	pgdat_remove_read_unlock();
 	return page;
 }
 
@@ -1536,10 +1549,21 @@ __alloc_pages_internal(gfp_t gfp_mask, u
 		return NULL;
 
 restart:
+	pgdat_remove_read_lock();
+	if (unlikely(!node_online(zonelist_nid))) {
+		/*
+		 * pgdat removing worked before here.
+		 * zone & zonelist can't be touched.
+		 */
+		pgdat_remove_read_unlock();
+		goto nopage;
+	}
 	zonelist = node_zonelist(zonelist_nid, gfp_mask);;
 	z = zonelist->_zonerefs;  /* the list of zones suitable for gfp_mask */
+	zone = z->zone;
+	pgdat_remove_read_unlock();
 
-	if (unlikely(!z->zone)) {
+	if (unlikely(!zone)) {
 		/*
 		 * Happens if we have an empty zonelist as a result of
 		 * GFP_THISNODE being used on a memoryless node
@@ -1565,9 +1589,17 @@ restart:
 	if (NUMA_BUILD && (gfp_mask & GFP_THISNODE) == GFP_THISNODE)
 		goto nopage;
 
+	pgdat_remove_read_lock();
+
+	if (unlikely(!node_online(zonelist_nid))) {
+		pgdat_remove_read_unlock();
+		goto nopage;
+	}
 	for_each_zone_zonelist(zone, z, zonelist, high_zoneidx)
 		wakeup_kswapd(zone, order);
 
+	pgdat_remove_read_unlock();
+
 	/*
 	 * OK, we're below the kswapd watermark and have kicked background
 	 * reclaim. Now things get more complex, so set up alloc_flags according

-- 
Yasunori Goto 


--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/