lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Thu, 31 Jul 2008 05:44:01 -0700 (PDT) From: David Miller <davem@...emloft.net> To: nickpiggin@...oo.com.au Cc: jarkao2@...il.com, johannes@...solutions.net, netdev@...eo.de, peterz@...radead.org, Larry.Finger@...inger.net, kaber@...sh.net, torvalds@...ux-foundation.org, akpm@...ux-foundation.org, netdev@...r.kernel.org, linux-kernel@...r.kernel.org, linux-wireless@...r.kernel.org, mingo@...hat.com Subject: Re: Kernel WARNING: at net/core/dev.c:1330 __netif_schedule+0x2c/0x98() From: Nick Piggin <nickpiggin@...oo.com.au> Date: Thu, 31 Jul 2008 22:38:19 +1000 > Except for the braindead volatile that gets stuck on the bitops pointer. > > Last time I complained about this, a lot of noise was made and I think > Linus wanted it to stay around so we could pass volatile pointers to > bitops & co without warnings. I say we should just remove the volatile > and kill any callers that might warn... Ho hum... :) Another way to approach that, and keep the volatile, is to have a "test_flags()" interface that takes the bit mask of values you want to test for cases where you know it is a single word flags value. The downside is that this kind of interface is easy to use incorrectly especially when accesses to the same flags use bot test_bit() and test_flags(). -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists