linux-kernel - RE: [PATCH] cciss: return -EFAULT if copy_from

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [thread-next>] [day] [month] [year] [list]

Message-ID: <0F5B06BAB751E047AB5C87D1F77A778826B3E814F0@GVW0547EXC.americas.hpqcorp.net>
Date:	Thu, 31 Jul 2008 14:12:08 +0000
From:	"Miller, Mike (OS Dev)" <Mike.Miller@...com>
To:	Nikanth Karthikesan <knikanth@...e.de>,
	LKML <linux-kernel@...r.kernel.org>,
	LKML-scsi <linux-scsi@...r.kernel.org>
CC:	ISS StorageDev <iss_storagedev@...com>,
	Jens Axboe <jens.axboe@...cle.com>
Subject: RE: [PATCH] cciss: return -EFAULT if copy_from_user() fails



> -----Original Message-----
> From: Nikanth Karthikesan [mailto:knikanth@...e.de]
> Sent: Thursday, July 31, 2008 1:06 AM
> To: Miller, Mike (OS Dev)
> Cc: ISS StorageDev; Jens Axboe
> Subject: [PATCH] cciss: return -EFAULT if copy_from_user() fails
>
> Return -EFAULT instead of -ENOMEM if copy_from_user() fails.
>
> Signed-off-by: Nikanth Karthikesan <knikanth@...e.de>

Acked-by: Mike Miller <mike.miller@...com>

>
> ---
>  drivers/block/cciss.c |    2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> Index: b/drivers/block/cciss.c
> ===================================================================
> --- a/drivers/block/cciss.c
> +++ b/drivers/block/cciss.c
> @@ -1134,7 +1134,7 @@ static int cciss_ioctl(struct inode *ino
>                                 if
> (ioc->Request.Type.Direction == XFER_WRITE) {
>                                         if (copy_from_user
>                                             (buff[sg_used],
> data_ptr, sz)) {
> -                                               status = -ENOMEM;
> +                                               status = -EFAULT;
>                                                 goto cleanup1;
>                                         }
>                                 } else {
>
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/