linux-kernel - Re: [PATCH] Removes extra checking in kernel/cpuset.c

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [day] [month] [year] [list]

Message-ID: <48920174.8000001@beta.intcomgrp.com>
Date:	Thu, 31 Jul 2008 14:16:20 -0400
From:	James Kosin <jkosin@...a.intcomgrp.com>
To:	linux-kernel@...r.kernel.org
Subject: Re: [PATCH] Removes extra checking in kernel/cpuset.c

Rakib Mullick wrote:
> Hello guys, this patch removes an extra checking over 'cs' in
> functions 'guarantee_online_cpus' and 'guarantee_online_mems'.
> 
> Thanks.
> 
> Signed-off-by: Md.Rakib H. Mullick (rakib.mullick@...il.com)
> 

I'd have to NAK this one as well.  2-reasons:
1)  Your patch is guaranteed to generate a NULL pointer dereference at 
some point.  You keep using cs; and assigning cs = cs->parent in the 
loop, at some point you may end up at the TOP of the tree where 
cs->parent == NULL.
2)  The change breaks the actual meaning of the code.  Which is 
suggesting my the short snippet, find an entry (while loop)... if the 
entry is found (if cs test), do this otherwise BUG out.  Your code is 
saying, if cs is not NULL initially... find someplace then do something. 
  The function never BUGS out unless someone calls with cs NULL initially.

James Kosin

Download attachment "signature.asc" of type "application/pgp-signature" (259 bytes)