| lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
|
Open Source and information security mailing list archives
| ||
|
Message-ID: <7c86c4470807301726m7b828621le272400bca6bdf6a@mail.gmail.com> Date: Wed, 30 Jul 2008 17:26:10 -0700 From: "stephane eranian" <eranian@...glemail.com> To: "Stephen Rothwell" <sfr@...b.auug.org.au> Cc: linux-kernel@...r.kernel.org Subject: Re: [patch 00/19] perfmon2 minimal v3: introduction Stephen On Wed, Jul 30, 2008 at 5:21 PM, Stephen Rothwell <sfr@...b.auug.org.au> wrote: > Hi Stephane, > > On Wed, 30 Jul 2008 16:59:34 -0700 "stephane eranian" <eranian@...glemail.com> wrote: >> >> On Mon, Jul 28, 2008 at 11:20 PM, stephane eranian >> <eranian@...glemail.com> wrote: >> >> quite a few of the macros (especially for the dummy (non >> >> CONFIG_PERFMON) versions of functions) should be "static inline" >> >> functions unless they absolutely must be macros. Andrew Morton said it >> >> best - "write in C not C preprocessor". >> >> >> Do you also have a problem with the debug printk statements using macros? > > Not really, they would be a pain to write as C code. > That's what I am thinking as well! > The advantage of using C code for the dummy versions of things is that we > still get type checking and we eliminate "unused variable" warnings for > parameters of the functions. > Will do the dummy functions as inline then. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists