linux-kernel - Re: [PATCH] drivers/net/skfp/pmf.c: Use offsetof() macro

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20080731235614.7e9e4fa7@lxorguk.ukuu.org.uk>
Date:	Thu, 31 Jul 2008 23:56:14 +0100
From:	Alan Cox <alan@...rguk.ukuu.org.uk>
To:	Takashi Iwai <tiwai@...e.de>
Cc:	Andrew Morton <akpm@...ux-foundation.org>,
	linux-kernel@...r.kernel.org, netdev@...r.kernel.org
Subject: Re: [PATCH] drivers/net/skfp/pmf.c: Use offsetof() macro

On Thu, 31 Jul 2008 18:55:06 +0200
Takashi Iwai <tiwai@...e.de> wrote:

> Self-baked macros cause bunch of compile warnings like below:
> 
>   CC [M]  drivers/net/skfp/pmf.o
>   CC      net/ipv4/fib_semantics.o
> drivers/net/skfp/pmf.c:86: warning: cast from pointer to integer of different size
> drivers/net/skfp/pmf.c:87: warning: cast from pointer to integer of different size
> ...
> 
> Use the standard offsetof() macro instead.
> 
> Signed-off-by: Takashi Iwai <tiwai@...e.de>

Acked-by: Alan Cox <alan@...hat.com>

(And this is better than the patch I sent to netdev so Ack in definite
preference to the one I posted)
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/