linux-kernel - RE: [RFC][PATCH 1/1] cxgb3i: cxgb3 iSCSI initiator

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <8A71B368A89016469F72CD08050AD334032EC7F5@maui.asicdesigners.com>
Date:	Wed, 30 Jul 2008 18:24:05 -0700
From:	"Karen Xie" <kxie@...lsio.com>
To:	"Jeff Garzik" <jgarzik@...ox.com>
Cc:	<netdev@...r.kernel.org>, <open-iscsi@...glegroups.com>,
	<davem@...emloft.net>, <michaelc@...wisc.edu>,
	"Steve Wise" <swise@...ngridcomputing.com>, <rdreier@...co.com>,
	<daisyc@...ibm.com>, <wenxiong@...ibm.com>, <bhua@...ibm.com>,
	"Divy Le Ray" <divy@...lsio.com>,
	"Dimitrios Michailidis" <dm@...lsio.com>,
	"Casey Leedom" <leedom@...lsio.com>,
	"linux-scsi" <linux-scsi@...r.kernel.org>,
	"LKML" <linux-kernel@...r.kernel.org>
Subject: RE: [RFC][PATCH 1/1] cxgb3i: cxgb3 iSCSI initiator

>Comments:
>
>* SCSI drivers should be submitted via the linux-scsi@...r.kernel.org 
>mailing list.

Will do that. Thanks.

>
>* The driver is clean and readable, well done
>
>* From a networking standpoint, our main concern becomes how this 
>interacts with the networking stack.  In particular, I'm concerned
based 
>on reading the source that this driver uses "TCP port stealing" rather 
>than using a totally separate MAC address (and IP).
>
>Stealing a TCP port on an IP/interface already assigned is a common 
>solution in this space, but also a flawed one.  Precisely because the 
>kernel and applications are unaware of this "special, magic TCP port" 
>you open the potential for application problems that are very difficult

>for an admin to diagnose based on observed behavior.

The collisions between the host stack and iSCSI offload are unlikely
because the iSCSI target server's port is unique (nailed down as 3260).
If an offload card is plugged in, all iSCSI connections to a given
target (i.e., destination/port) are offloaded. There is precedence for
this approach such as RDMA/iWarp.

>
>So, additional information on your TCP port usage would be greatly 
>appreciated.  Also, how does this interact with IPv6?  Clearly it 
>interacts with IPv4...

Currently, IPv6 connection request will not be honored, I will make sure
the checking is added in the resubmission.

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/