linux-kernel - Re: [PATCH 2/3] binfmt_elf_fdpic: Convert initial stack alignment to arch_align

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <27552.1217599279@redhat.com>
Date:	Fri, 01 Aug 2008 15:01:19 +0100
From:	David Howells <dhowells@...hat.com>
To:	Paul Mundt <lethal@...ux-sh.org>
Cc:	dhowells@...hat.com, Andrew Morton <akpm@...ux-foundation.org>,
	linux-sh@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH 2/3] binfmt_elf_fdpic: Convert initial stack alignment to arch_align_stack().

Paul Mundt <lethal@...ux-sh.org> wrote:

> +	 * In some cases (e.g. Hyper-Threading), we want to avoid L1
> +	 * evictions by the processes running on the same package. One
> +	 * thing we can do is to shuffle the initial stack for them, so
> +	 * we give the architecture an opportunity to do so here.
> +	 */
>  #ifdef CONFIG_MMU
> -	sp = bprm->p;
> +	sp = arch_align_stack(bprm->p);
>  #else
> -	sp = mm->start_stack;
> +	sp = arch_align_stack(mm->start_stack);

Ummm...  You're calling arch_align_stack() under NOMMU...  Is that really a
good idea?

You can't necessarily move the stack pointer without exiting the allocated
region or shrinking the amount of stack space the executable asked for.  If
you want to do this sort of thing, you need to tell the memory allocator what
you're up to - or at the very least allocate some slack.

David
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/