linux-kernel - Re: x86 BIOS interface for partitioning and system serial number on SGI UV

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <48934926.2010200@zytor.com>
Date:	Fri, 01 Aug 2008 10:34:30 -0700
From:	"H. Peter Anvin" <hpa@...or.com>
To:	Russ Anderson <rja@....com>
CC:	mingo@...e.hu, tglx@...utronix.de, linux-kernel@...r.kernel.org,
	Jack Steiner <steiner@....com>
Subject: Re: x86 BIOS interface for partitioning and system serial number
 on SGI UV

Russ Anderson wrote:
> x86 BIOS interface for partitioning and system serial number on SGI UV

> -	if (!proc_mkdir("sgi_uv", NULL))
> +	if (!sgi_uv_dir)
> +		sgi_uv_dir = proc_mkdir("sgi_uv", NULL);
> +	if (!sgi_uv_dir)
>  		return -EINVAL;

This really seems more that it should belong in sysfs -- 
/sys/class/firmware presumably.

> +# define BIOS_CALL(result, a0, a1, a2, a3, a4, a5, a6, a7)		\
> +	do {								\
> +		/* XXX - the real call goes here */			\
> +		result.status = BIOS_STATUS_UNIMPLEMENTED;		\
> +		result.v0 = 0;						\
> +		result.v1 = 0;						\
> +	} while (0)

I have more than a little problem with submitting patches like this.  We 
have no way to judge the suitability of the coding or the interface with 
the "meat" of the driver stubbed out!

	-hpa
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/