linux-kernel - Re: [PATCH] OLPC: psmouse: touchpad driver

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20080801143150.ZZRA012@mailhub.coreip.homeip.net>
Date:	Fri, 1 Aug 2008 14:34:51 -0400
From:	Dmitry Torokhov <dmitry.torokhov@...il.com>
To:	Andres Salomon <dilinger@...ued.net>
Cc:	linux-input@...r.kernel.org,
	Andrew Morton <akpm@...ux-foundation.org>,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH] OLPC: psmouse: touchpad driver

On Fri, Aug 01, 2008 at 02:20:04PM -0400, Andres Salomon wrote:
> 
> This adds support for OLPC's touchpad.  It has lots of neat features,
> none of which are enabled because the hardware is too buggy.  Instead,
> we use it like a normal touchpad, but with a number of workarounds in
> place to deal with the frequent hardware spasms.  Humidity changes,
> sweat, tinfoil underwear, plugging in AC, drinks, evil felines.. All
> tend to cause the touchpad to freak out.
> 
> Stuff like this keeps me from getting bored.
> 

Good stuff, thank you. I bet you named the module olpc and gave pregix
hgpk to all the functions to mess with mt feeble brain ;) Maybe we
should rename the module to hgpk as well?

> From psmouse-base, we use psmouse_set_state quite a bit, as well
> as piggy-backing off of kpsmoused_wq; so, this also makes those
> available to protocol extensions.
>

Do you think we should provide assessor functions to deal with
kpsmoused instead of playing with it directly? I was thinking about
starting it on-demand for protocols that may use it and shut it off by
default.

-- 
Dmitry
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/