linux-kernel - Re: [PATCH 00/16] dyn_array and nr

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <m1iqukwjjg.fsf@frodo.ebiederm.org>
Date:	Fri, 01 Aug 2008 13:46:11 -0700
From:	ebiederm@...ssion.com (Eric W. Biederman)
To:	Yinghai Lu <yhlu.kernel@...il.com>
Cc:	Ingo Molnar <mingo@...e.hu>, Thomas Gleixner <tglx@...utronix.de>,
	hpa <hpa@...or.com>, Dhaval Giani <dhaval@...ux.vnet.ibm.com>,
	Mike Travis <travis@....com>,
	Andrew Morton <akpm@...ux-foundation.org>,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH 00/16] dyn_array and nr_irqs support v2

Yinghai Lu <yhlu.kernel@...il.com> writes:

> Please check dyn_array support for x86

YH you have not addressed any of my core concerns and this exceeds my review limit.
Unfortunately I don't feel like this is a productive process.

My core concerns are:
- You have not separated out and separately pushed the regression patch.  So that we can
  fix the current rc release.  Simply tuning NR_IRQS is all I feel comfortable with for
  fixing things in the post merge window period.

- The generic code has no business with dealing with NR_IRQS sized arrays.
  Since we don't have a generic problem I don't see why we should have a generic dyn_array solution.

- The dyn_array infrastructure does not provide for per numa node allocation of
  irq_desc structures, limiting NUMA scalability.

- You appear to be papering over problems instead of digging in and actually fixing them.

YH  Here is what I was suggesting when the topic of killing NR_IRQs came up a week or so
ago.
http://lkml.org/lkml/2008/7/10/439
http://lkml.org/lkml/2008/7/10/532

Which essentially boils down to:
- Removing NR_IRQS from the non-irq infrastructure code.
- Add a config option for architectures that are not going to use an array
- In the genirq code have a lookup function that goes from irq number to irq_desc *.

The rest we should be able to handle in a arch dependent fashion.

When we are done we should be able to create a stable irq number for msi interrupts
that is something like:  bus:dev:fun:vector_no which is 8+5+3+12=28 bits long.

Eric
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/