linux-kernel - Re: [PATCH] lockdep: lock_set_subclass

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20080801.162013.06459319.davem@davemloft.net>
Date:	Fri, 01 Aug 2008 16:20:13 -0700 (PDT)
From:	David Miller <davem@...emloft.net>
To:	hugh@...itas.com
Cc:	jeremy@...p.org, torvalds@...ux-foundation.org,
	a.p.zijlstra@...llo.nl, mingo@...e.hu,
	linux-kernel@...r.kernel.org, akpm@...ux-foundation.org
Subject: Re: [PATCH] lockdep: lock_set_subclass - reset a held lock's
 subclass

From: Hugh Dickins <hugh@...itas.com>
Date: Fri, 1 Aug 2008 20:59:08 +0100 (BST)

> On Fri, 1 Aug 2008, Jeremy Fitzhardinge wrote:
> > 
> > I have a function traversing a pagetable in vaddr order (low to high), taking
> > pte locks as it builds up batches of pte page updates.  When the batch is
> > issued, it releases all the locks, and won't end up holding more than ~16 at a
> > time.
> > 
> > So, I think this is OK.  There are no internal lock ordering issues, and I
> > don't think there'll be any bad interactions from someone trying to take pte
> > locks for two separate pagetables.  I don't think there's anyone else trying
> > to take more than one pte lock at once, but if there were "lock low vaddr then
> > high" seems like a reasonable locking rule (or more precisely "lowest" to deal
> > with the case of a pte page being aliased at multiple vaddrs).
> 
> Please check the spin_lock_nested() in move_ptes() in mm/mremap.c.

It won't work because spin_lock_nested() is limited to a depth
of 8 and he aparently needs 16.

Taking more than a few locks of the same class at once is bad
news and it's better to find an alternative method.

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/