linux-kernel - Re: [PATCH 2/6] Container Freezer: Make refrigerator always available

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <1217633074.25300.281.camel@localhost.localdomain>
Date:	Fri, 01 Aug 2008 16:24:34 -0700
From:	Matt Helsley <matthltc@...ibm.com>
To:	"Rafael J. Wysocki" <rjw@...k.pl>
Cc:	Andrew Morton <akpm@...ux-foundation.org>,
	Thomas Petazzoni <thomas.petazzoni@...e-electrons.com>,
	Paul Menage <menage@...gle.com>,
	Li Zefan <lizf@...fujitsu.com>,
	Linux-Kernel <linux-kernel@...r.kernel.org>,
	Linux Containers <containers@...ts.linux-foundation.org>,
	linux-pm@...ts.linux-foundation.org,
	Cedric Le Goater <clg@...ibm.com>,
	"Serge E. Hallyn" <serue@...ibm.com>,
	Michael Opdenacker <michael@...e-electrons.com>,
	linux-embedded@...r.kernel.org
Subject: Re: [PATCH 2/6] Container Freezer: Make refrigerator always
	available


On Sat, 2008-08-02 at 00:53 +0200, Rafael J. Wysocki wrote:
> On Friday, 1 of August 2008, Matt Helsley wrote:
> > 
> > On Fri, 2008-08-01 at 16:27 +0200, Thomas Petazzoni wrote:
> > > Hi,
> > > 
> > > Le Thu, 31 Jul 2008 22:07:01 -0700,
> > > Matt Helsley <matthltc@...ibm.com> a écrit :
> > > 
> > > > --- a/kernel/Makefile
> > > > +++ b/kernel/Makefile
> > > > @@ -5,7 +5,7 @@
> > > >  obj-y     = sched.o fork.o exec_domain.o panic.o printk.o \
> > > >  	    cpu.o exit.o itimer.o time.o softirq.o resource.o \
> > > >  	    sysctl.o capability.o ptrace.o timer.o user.o \
> > > > -	    signal.o sys.o kmod.o workqueue.o pid.o \
> > > > +	    signal.o sys.o kmod.o workqueue.o pid.o freezer.o \
> > > 
> > > I have the impression that the code in kernel/power/process.c was
> > > compiled only if CONFIG_PM_SLEEP was set. Now that the code has been
> > > moved to kernel/freezer.c, it is unconditionnaly compiled in every
> > > kernel. Is that correct ?
> > >
> > > If so, is it possible to put this new feature under some
> > > CONFIG_SOMETHING option, for people who care about the kernel size ?
> > 
> > 	How about making it depend on a combination of CONFIG variables?
> > Here's an RFC PATCH. Completely untested.
> > 
> > Signed-off-by: Matt Helsley <matthltc@...ibm.com>
> 
> Can you please also make the contents of include/linux/freezer.h depend on
> CONFIG_FREEZER instead of CONFIG_PM_SLEEP?

Good point -- I'll add that to this patch and repost.

> Also, I'm not really sure if kernel/power/Kconfig is the right place to define
> CONFIG_FREEZER.

	There's no nice place to put it since we're dealing with CONFIG_
variables in two different Kconfig files. I put it in
kernel/power/Kconfig because I wasn't certain Kbuild would do the right
thing if I referenced PM_SLEEP from init/Kconfig.

> Perhaps we should even move freezer.c from kernel/power to kernel

It's already there. Perhaps you meant something else
(kernel/power/process.c?)?

> and define CONFIG_FREEZER in Kconfig in there.  Andrew, what do you think?

The Kconfig files in kernel/ are Kconfig.hz and Kconfig.preemt which
don't seem appropriate. I suppose we could add another (perhaps
Kconfig.cgroup).

Thanks for the review!

Cheers,
	-Matt

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/