linux-kernel - Re: [RFC, 2.6.26.2-rc1] exec: remove some includes

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <Pine.LNX.4.64.0808022046310.20316@blonde.site>
Date:	Sat, 2 Aug 2008 20:53:32 +0100 (BST)
From:	Hugh Dickins <hugh@...itas.com>
To:	Linus Torvalds <torvalds@...ux-foundation.org>
cc:	Oliver Pinter <oliver.pntr@...il.com>, stable@...nel.org,
	Andrew Morton <akpm@...ux-foundation.org>,
	linux-kernel@...r.kernel.org
Subject: Re: [RFC, 2.6.26.2-rc1] exec: remove some includes

On Sat, 2 Aug 2008, Linus Torvalds wrote:
> On Sat, 2 Aug 2008, Oliver Pinter wrote:
> > 
> > [ Upstream commit ba92a43dbaee339cf5915ef766d3d3ffbaaf103c ]
> > 
> > fs/exec.c used to need mman.h pagemap.h swap.h and rmap.h when it did
> > mm-ish stuff in install_arg_page(); but no need for them after 2.6.22.
> 
> Why on earth would this be -stable material?

Of course it isn't -stable material, I don't know what Oliver's on.

Maybe he noticed akpm's "unbreak arm" comment and thought it was
fixing some pre-existing breakage: no, akpm restored swap.h to
fix the arm build.  Then after this commit, we had to restore
pagemap.h to fix avr32 and !CONFIG_SWAP builds.

Prime material for -unstable, I'm ashamed to say.

Hugh
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/