linux-kernel - Re: [PATCH 1/2] pata_legacy: export functionality to ide

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20080803125907.67676948@lxorguk.ukuu.org.uk>
Date:	Sun, 3 Aug 2008 12:59:07 +0100
From:	Alan Cox <alan@...rguk.ukuu.org.uk>
To:	petkovbb@...il.com
Cc:	petkovbb@...glemail.com,
	Bartlomiej Zolnierkiewicz <bzolnier@...il.com>,
	alan@...hat.com, linux-kernel@...r.kernel.org,
	linux-ide@...r.kernel.org
Subject: Re: [PATCH 1/2] pata_legacy: export functionality to ide

On Sun, 3 Aug 2008 09:37:56 +0200
Borislav Petkov <petkovbb@...glemail.com> wrote:

> Ok, here's a definitely better solution:

Please don't stuff large important pieces of code in header files where
they will be overlooked

NAK this.

I'm happy to have a shared library directory for ATA stuff, containing
useful C code, but hiding stuff in headers like that is just plain wrong.

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/