linux-kernel - Re: [PATCH 2/2] ide-generic: handle probing of legacy io-ports

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <200808031659.55953.bzolnier@gmail.com>
Date:	Sun, 3 Aug 2008 16:59:55 +0200
From:	Bartlomiej Zolnierkiewicz <bzolnier@...il.com>
To:	petkovbb@...il.com
Cc:	alan@...hat.com, linux-kernel@...r.kernel.org,
	linux-ide@...r.kernel.org
Subject: Re: [PATCH 2/2] ide-generic: handle probing of legacy io-ports

On Sunday 03 August 2008, Borislav Petkov wrote:

[...]

> > > +		if (probe_mask) {
> > > +			printk(KERN_WARNING "%s: enforcing probing of io ports "
> > > +			       "upon user request.\n", DRV_NAME);
> > > +			primary = 0;
> > > +			secondary = 0;
> > > +		} else
> > > +			printk(KERN_INFO DRV_NAME ": please use "
> > > +			       \"probe_mask=0x3f\" module parameter for probing"
> > > +			       "all legacy ISA IDE ports\n");
> > 
> > Help message is no longer printed for !primary
> > (we always want to have it unless probe_mask is set).
> 
> How about moving that info to Documentation/ide/ide.txt instead? Do we want to
> issue that on every boot, seems like a too unimportant message to be in the
> bootlog to me...

Some time ago we've changed the default from probing all ports to probe
only safe ones (we had to do it because probing all ports may break other
ISA devices) so there may be very unlikely cases when this bugfix caused
regression and we would like people to be able to deduce the workaround
from just reading kernel messages.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/