linux-kernel - [RFC/RFT] p54usb: Regression due to commit b19fa1f

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <48961182.5030800@lwfinger.net>
Date:	Sun, 03 Aug 2008 15:13:54 -0500
From:	Larry Finger <Larry.Finger@...inger.net>
To:	Michael Wu <flamingice@...rmilk.net>
CC:	"David S. Miller" <davem@...emloft.net>,
	wireless <linux-wireless@...r.kernel.org>,
	LKML <linux-kernel@...r.kernel.org>
Subject: [RFC/RFT] p54usb: Regression  due to commit b19fa1f

In commit b19fa1fa91845234961c64dbd564671aa7c0fd27, the configuration
parameter NETDEVICES_MULTIQUEUE was eliminated making multiple TX queues
the normal behavior. For p54usb, enabling multiple queues broke the driver.

A temporary hack that forces only one queue is presented here. With it, the 
driver works as before. Obviously, a proper fix is needed in the long run.

Signed-off-by: Larry Finger <Larry.Finger@...inger.net>
---


Index: linux-2.6/drivers/net/wireless/p54/p54common.c
===================================================================
--- linux-2.6.orig/drivers/net/wireless/p54/p54common.c
+++ linux-2.6/drivers/net/wireless/p54/p54common.c
@@ -150,7 +150,7 @@ void p54_parse_firmware(struct ieee80211
  		priv->tx_stats[1].limit = 4;
  		priv->tx_stats[2].limit = 3;
  		priv->tx_stats[3].limit = 1;
-		dev->queues = 4;
+		dev->queues = 1; /* temp. hack, set to 1 as 4 breaks p54usb */
  	}
  }
  EXPORT_SYMBOL_GPL(p54_parse_firmware);



View attachment "p54usb_fix" of type "text/plain" (903 bytes)