linux-kernel - Re: [PATCH 03/25] add dyn

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <87sktm1yuu.fsf@saeurebad.de>
Date:	Sun, 03 Aug 2008 06:55:37 +0200
From:	Johannes Weiner <hannes@...urebad.de>
To:	"Yinghai Lu" <yhlu.kernel@...il.com>
Cc:	"Ingo Molnar" <mingo@...e.hu>,
	"Thomas Gleixner" <tglx@...utronix.de>,
	"H. Peter Anvin" <hpa@...or.com>,
	"Eric W. Biederman" <ebiederm@...ssion.com>,
	"Dhaval Giani" <dhaval@...ux.vnet.ibm.com>,
	"Mike Travis" <travis@....com>,
	"Andrew Morton" <akpm@...ux-foundation.org>,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH 03/25] add dyn_array support

Hi,

"Yinghai Lu" <yhlu.kernel@...il.com> writes:

> On Sat, Aug 2, 2008 at 9:03 PM, Johannes Weiner <hannes@...urebad.de> wrote:
>> Hi,
>>
>> Yinghai Lu <yhlu.kernel@...il.com> writes:
>>
>>> could have crazy big arrays and allocate them in bootmem at init stage.
>>> also also to allocate array according to size we need to use to avoid wasting
>>> memory
>>> use CONFIG_HAVE_DYN_ARRAY to enable it or not
>>>
>>> usage:
>>>
>>> |static struct irq_desc irq_desc_init __initdata = {
>>> |       .status = IRQ_DISABLED,
>>> |       .chip = &no_irq_chip,
>>> |       .handle_irq = handle_bad_irq,
>>> |       .depth = 1,
>>> |       .lock = __SPIN_LOCK_UNLOCKED(irq_desc->lock),
>>> |#ifdef CONFIG_SMP
>>> |       .affinity = CPU_MASK_ALL
>>> |#endif
>>> |};
>>> |
>>> |static void __init init_work(void *data)
>>> |{
>>> |       struct dyn_array *da = data;
>>> |       struct  irq_desc *desc;
>>> |       int i;
>>> |
>>> |       desc = *da->name;
>>
>> Where *da->name might be NULL...
>
> you can not pass compiling
>
> +#define DEFINE_DYN_ARRAY(nameX, sizeX, nrX, alignX, init_workX) \
> +               static struct dyn_array __dyn_array_##nameX __initdata = \
> +               {       .name = (void **)&nameX,\

I didn't mean da->name.  Please reread my email, including the part you
stripped off in the reply.

> +                       .size = sizeX,\
> +                       .nr   = &nrX,\
> +                       .align = alignX,\
> +                       .init_work = init_workX,\
> +               }; \
> +               static struct dyn_array *__dyn_array_ptr_##nameX __used \
> +               __attribute__((__section__(".dyn_array.init"))) = \
> +                       &__dyn_array_##nameX
> +
>
> YH

	Hannes
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/