linux-kernel - Re: regarding mprotect() implementation in 2.6.26 kernel

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <9debc4410808040319i3358a916v3b6cd534c0a0802c@mail.gmail.com>
Date:	Mon, 4 Aug 2008 15:49:01 +0530
From:	"Maxin John" <maxin.john@...il.com>
To:	"Jeremy Fitzhardinge" <jeremy@...p.org>
Cc:	linux-kernel@...r.kernel.org, ak@....de, mtk.manpages@...il.com,
	shields@...bel.org, hirofumi@...l.parknet.co.jp
Subject: Re: regarding mprotect() implementation in 2.6.26 kernel

Dear Jeremy,

              Thank you very much for the information and I am sorry
for my delayed reply.

        As per the patch created by Mr. hirofumi for the 2.5.26 kernel
which is described in
http://www.kernel.org/pub/linux/kernel/v2.5/ChangeLog-2.5.26 ,
and
http://linux.bkbits.net:8080/linux-2.6/?PAGE=gnupatch&REV=1.403.147.22
, the mprotect system call will set errno as ENOMEM instead of
EFAULT.

But the latest man page(man-pages-3.05) of mprotect still contains
information regarding EFAULT. The SuSv3 specification of mprotect also
doesn't say anything about EFAULT in the mprotect() details. The
following patch removes the information regarding EFAULT from the
mprotect man page.

diff -Naur man-pages-3.05/man2/mprotect.2
man-pages-3.05_modified/man2/mprotect.2
--- man-pages-3.05/man2/mprotect.2      2008-07-23 19:42:13.000000000 +0530
+++ man-pages-3.05_modified/man2/mprotect.2     2008-08-04
15:34:33.400869088 +0530
@@ -87,9 +87,6 @@
 to mark it
 .BR PROT_WRITE .
 .TP
-.B EFAULT
-The memory cannot be accessed.
-.TP
 .B EINVAL
 \fIaddr\fP is not a valid pointer,
 or not a multiple of the system page size.
~

  Please advise me if this information is irrelevant or wrong.

Thanks and Regards,

Maxin B. John
Bangalore, India.


On Thu, Jul 31, 2008 at 8:39 PM, Jeremy Fitzhardinge <jeremy@...p.org> wrote:
> Maxin John wrote:
>> Dear Christoph Hellwig,
>>
>> ( I guess you are the right person to ask this question ?)
>>
>> The POSIX.2 specification of mprotect() says:
>>
>> errorno should be set as ENOMEM if the addresses in the range [addr,
>> (addr + len)] are invalid for the address space of a process, or
>> specify one or more pages which are not mapped.
>>
>> However, in the mprotect implementation  (asmlinkage long
>> sys_mprotect(unsigned long start, size_t len, unsigned long prot)) in
>> linux/mm/mprotect.c file, if we call mprotect() with start as NULL and
>> len as 0, mprotect() returns 0 and it is not setting the errono.The
>> following code confirms this behaviour.
>>
>
> Address 0 is a valid process address.  And you've set the length to
> zero, so you technically haven't referred to any memory at all, so it
> doesn't matter what the address is.
>
>    J
>
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/