linux-kernel - Re: [PATCH] cpuset: Add comments for update_domain_attr

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <6599ad830808040927h333a7841y411187833f38c1ac@mail.gmail.com>
Date:	Mon, 4 Aug 2008 09:27:30 -0700
From:	"Paul Menage" <menage@...gle.com>
To:	"Lai Jiangshan" <laijs@...fujitsu.com>
Cc:	"Andrew Morton" <akpm@...ux-foundation.org>,
	"Paul Jackson" <pj@....com>,
	"Hidetoshi Seto" <seto.hidetoshi@...fujitsu.com>,
	"Li Zefan" <lizf@...fujitsu.com>,
	"Linux Kernel Mailing List" <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] cpuset: Add comments for update_domain_attr_tree

On Thu, Jul 31, 2008 at 12:42 AM, Lai Jiangshan <laijs@...fujitsu.com> wrote:
>
> This patch was reviewed by Li Zefan and was revised on his suggestion before sent.
> Thanks Li Zefan.
>
> Reviewed-by: Li Zefan <lizf@...fujitsu.com>
>
> Lai Jiangshan wrote:
>> Add comments for update_domain_attr_tree().
>>
>> Signed-off-by: Lai Jiangshan <laijs@...fujitsu.com>
>> ---
>> diff --git a/kernel/cpuset.c b/kernel/cpuset.c
>> index adf66c0..fed1f42 100644
>> --- a/kernel/cpuset.c
>> +++ b/kernel/cpuset.c
>> @@ -487,15 +487,21 @@ update_domain_attr(struct sched_domain_attr *dattr, struct cpuset *c)
>>  {
>>       if (dattr->relax_domain_level < c->relax_domain_level)
>>               dattr->relax_domain_level = c->relax_domain_level;
>> -     return;
>>  }
>>
>> +/*

If you're going to add a comment block, maybe it's worth making it
docbook-compatible? So /** at the start, and then following the proper
docbook style conventions in kernel-doc-nano-HOWTO.txt ?

Paul
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/