linux-kernel - Re: [PATCH] JMicron JM20337 USB-SATA data corruption bugfix

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <Pine.LNX.4.44L0.0808041245430.15613-100000@iolanthe.rowland.org>
Date:	Mon, 4 Aug 2008 12:48:09 -0400 (EDT)
From:	Alan Stern <stern@...land.harvard.edu>
To:	Alex Buell <alex.buell@...ted.org.uk>
cc:	linux-kernel@...r.kernel.org, Robert Hancock <hancockr@...w.ca>,
	Tomas Styblo <tripie@...n.org>, <linux-usb@...r.kernel.org>,
	<usb-storage@...ts.one-eyed-alien.net>
Subject: Re: [PATCH] JMicron JM20337 USB-SATA data corruption bugfix - device
 152d:2338

On Sun, 3 Aug 2008, Alex Buell wrote:

> > Which patch?  Several different ones have been posted.
> 
> This is the one that I applied:
> Index: usb-2.6/drivers/usb/storage/transport.c
> ===================================================================
> --- usb-2.6.orig/drivers/usb/storage/transport.c
> +++ usb-2.6/drivers/usb/storage/transport.c
> @@ -663,7 +663,7 @@ void usb_stor_invoke_transport(struct sc
>  	}
>  
>  	/* Did we transfer less than the minimum amount required? */
> -	if (srb->result == SAM_STAT_GOOD &&
> +	if ((srb->result == SAM_STAT_GOOD || srb->sense_buffer[2] == 0) && scsi_bufflen(srb) - scsi_get_resid(srb) < srb->underflow)
>  		srb->result = (DID_ERROR << 16) | (SUGGEST_RETRY << 24); 
> 
> > The log doesn't provide much help.  We need to see a log with 
> > CONFIG_USB_STORAGE_DEBUG enabled.
> 
> Which patch should I be trying out? 

That's the right patch.  You should use it with 2.6.27-rc1.

I just got one of those JMicron thingies; I'll try it out later today.  
No SATA devices available for testing, though, only PATA.

Alan Stern

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/