linux-kernel - [PATCH] Remove redundant condition from map_buffer_to

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [day] [month] [year] [list]

Message-ID: <ea11fea30808041127u3c35b268l7ad193c415e9af5a@mail.gmail.com>
Date:	Mon, 4 Aug 2008 23:57:15 +0530
From:	"Manish Katiyar" <mkatiyar@...il.com>
To:	kernel-janitors@...r.kernel.org, trivial@...nel.org,
	LKML <linux-kernel@...r.kernel.org>
Cc:	mkatiyar@...il.com
Subject: [PATCH] Remove redundant condition from map_buffer_to_page

Currently the only caller to this function is do_mpage_readpage()
which already checks if the buffer is uptodate, so a check inside is
not required.

Signed-off-by:- "Manish Katiyar" <mkatiyar@...il.com>

---
 fs/mpage.c |    3 +--
 1 files changed, 1 insertions(+), 2 deletions(-)

diff --git a/fs/mpage.c b/fs/mpage.c
index dbcc7af..a797de1 100644
--- a/fs/mpage.c
+++ b/fs/mpage.c
@@ -135,8 +135,7 @@ map_buffer_to_page(struct page *page, struct
buffer_head *bh, int page_block)
 		 * don't make any buffers if there is only one buffer on
 		 * the page and the page just needs to be set up to date
 		 */
-		if (inode->i_blkbits == PAGE_CACHE_SHIFT &&
-		    buffer_uptodate(bh)) {
+		if (inode->i_blkbits == PAGE_CACHE_SHIFT) {
 			SetPageUptodate(page);
 			return;
 		}
-- 
1.5.4.3



Thanks -
Manish
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/